fix: follow-up fixes on bootstrappingclient mode after integration testing with v1 #544
+28
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovisionProfile in bootstrappingclient mode
Pull Request Test Coverage Report for Build 11547194060Details
💛 - Coveralls |
comtalyst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
KubeletConfig retrieved from nodeClaim doesn't seem to have a proper defaulting(?), which could returns invalid values (e.g., out of range) when populating ProvisionProfile. The logic added here should isolate non-pointer values (which cannot be "unpopulated" by being nil) and have an empty check.
Also, new unregistered startup taints defaulting method went under the radar during the merge, making it ineffective for CustomScripts bootstrapping. This should fix it, and have similar spots scanned.
How was this change tested?
Does this change impact docs?
Release Note